Fix: address feedback for Fedora package #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emansom
force-pushed
the
bugfix/address-rhel-feedback
branch
7 times, most recently
from
f703805 to
89cb40b
Compare
emansom
force-pushed
the
bugfix/address-rhel-feedback
branch
12 times, most recently
from
537b695 to
028580b
Compare
|
Fundamental changes. I will move the PR to a branch while it is stabilizing and I understand what is happening. |
emansom
force-pushed
the
bugfix/address-rhel-feedback
branch
from
028580b to
2acb602
Compare
petersulyok
merged commit d2fd025
into
petersulyok:tito_rpm_support
0 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback by @NeilHanlon from the Fedora package review request upstream here.
It was tedious to get the packaging thing to work alright, I opted for a semi hack in
__init__.pyas for some reason I couldn't get the setuptools packaged with EL to expand smfc.py to a full namespace. Inform me if there's a better way: i'm very much a novice in Python.Multiple Python build system compatibility layers are implemented: that's why there's an
setup.cfg,setup.pyandpyproject.tomlthat all contain the same definitions. This is to get the same behavior across all distros: EL ships with oldsetuptoolsand oldpyprojectthat don't behave the same as their latest versions would.Split the files for better maintainability and sanity. Currently this does break the Docker support, will fix this before merge (hence it's a draft).
Per feedback I have replaced all
/optreferences with/etc. The .spec file has further been enhanced to build and test the smfc code. Package has also been split in two:smfcandpython3-smfcas dependency.The file structure has been altered to a flat package structure to make pyproject happy. Further several system-wide files have been moved to more descriptive directories.